RE: POC: enable logical decoding when wal_level = 'replica' without a server restart

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: POC: enable logical decoding when wal_level = 'replica' without a server restart
Date: 2025-12-24 08:41:58
Message-ID: TY4PR01MB16907680E27BAB146C8EB1A4294B2A@TY4PR01MB16907.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed a BF failure [1] related to this commit.

Commit 67c209 removes the WARNING for insufficient wal_level from the output,
but the WARNING may still appear on BF animals that default to
wal_level=minimal.

To avoid tests that produce varying messages based on wal_level, we could modify
the test to use ALTER PUBLICATION for verifying the same NOTICE. Attached is a
small patch addressing this issue.

We could also simply remove these tests but that seems to reduce the test
coverage a bit.

---- publication.out diff ----
SET client_min_messages = 'NOTICE';
CREATE PUBLICATION regress_pub_for_allsequences_alltables_withclause FOR ALL SEQUENCES, ALL TABLES WITH (publish = 'insert');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that &quot;wal_level&quot; is set to &quot;replica&quot; or higher.
CREATE PUBLICATION regress_pub_for_allsequences_withclause FOR ALL SEQUENCES WITH (publish_generated_columns = 'stored');
NOTICE: publication parameters are not applicable to sequence synchronization and will be ignored for sequences
+WARNING: logical decoding must be enabled to publish logical changes
+HINT: Before creating subscriptions, ensure that &quot;wal_level&quot; is set to &quot;replica&quot; or higher.

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=thorntail&dt=2025-12-24%2006%3A31%3A02

Best Regards,
Hou zj

Attachment Content-Type Size
v1-0001-Fix-regression-test-on-wal_level-minimal.patch application/octet-stream 4.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aya Iwata (Fujitsu) 2025-12-24 08:42:51 RE: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE
Previous Message Amit Kapila 2025-12-24 08:26:01 Re: Orphaned records in pg_replication_origin_status after subscription drop