Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases
Date: 2023-05-11 08:12:38
Message-ID: CAD21AoBBRSCNW0SrSzEpLi-8JMGHLnfuTJNxniXZVdYG14kkhA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 10, 2023 at 8:58 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
> Hi,
>
> Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, 8 May 2023 Pzt, 10:24 tarihinde şunu yazdı:
>>
>> I've attached the patch. Feedback is very welcome.
>
>
> Thanks for the patch, nice catch.
> I can confirm that the issue exists on HEAD and gets resolved by this patch. Also it looks like stats are really not affected if transaction fails for some reason, as you explained.
> IMO, the patch will be OK after commit message is added.

Thank you for reviewing the patch. I'll push the patch early next
week, barring any objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-05-11 08:30:38 Re: pg_upgrade - typo in verbose log
Previous Message Niyas Sait 2023-05-11 07:57:57 Re: [PATCH] Add native windows on arm64 support