From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_upgrade - typo in verbose log |
Date: | 2023-05-11 08:30:38 |
Message-ID: | 321AA924-E038-46DB-8370-F9BB59FBB94A@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 11 May 2023, at 07:41, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> While reviewing another patch for the file info.c, I noticed some
> misplaced colon (':') in the verbose logs for print_rel_infos().
That spelling was introduced in c2e9b2f28818 which was the initial import of
pg_upgrade into contrib/ for the 9.0 release (at that time the function was
relarr_print() which via a few other names was renamed to print_rel_infos() in
0a5f1199319).
It's not entirely clear to me if the current spelling is a mistake or
intentional, but I do agree that your version is an improvement.
To be consistent with other log output in pg_upgrade we should probably also
wrap the relname and reltblspace in quotes as \"%s.%s\" and \"%s\" (and the
Database in print_db_infos()).
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2023-05-11 08:36:30 | Re: [PATCH] Allow Postgres to pick an unused port to listen |
Previous Message | Masahiko Sawada | 2023-05-11 08:12:38 | Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases |