Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases

From: Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases
Date: 2023-05-10 11:58:26
Message-ID: CAGPVpCQd9G0w988zD9akUKpwXNjJwdA511+KW9Mn3OL_U6L=eg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, 8 May 2023 Pzt, 10:24 tarihinde
şunu yazdı:

> I've attached the patch. Feedback is very welcome.
>

Thanks for the patch, nice catch.
I can confirm that the issue exists on HEAD and gets resolved by this
patch. Also it looks like stats are really not affected if transaction
fails for some reason, as you explained.
IMO, the patch will be OK after commit message is added.

Thanks,
--
Melih Mutlu
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-10 12:04:38 Re: WAL Insertion Lock Improvements
Previous Message Amit Kapila 2023-05-10 10:41:37 Re: Add two missing tests in 035_standby_logical_decoding.pl