Re: [PostgreSQL 10] default of hot_standby should be "on"?

On Thu, Apr 27, 2017 at 9:54 AM, Huong Dangminh
<huo-dangminh(at)ys(dot)jp(dot)nec(dot)com> wrote:
> Thanks all for your comments.
>
>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> > +1. I definitely think we should do it, and 10 would be the time to do
>> it.
>>
>> Agreed. It's mainly a historical accident that the default is what it
>> is,
>> I think.
>>
>> > I wonder if we should also consider changing the standby error message
>> to
>> > be a WARNING instead of an ERROR. So that if you try to start up a standby
>> > with hot_standby=on but master with wal_level=replica it would turn into
>> a
>> > cold standby.
>>
>> I'm -1 for that: if you fat-finger the configuration, you should be told
>> about it, not have the system start up in an unintended mode that lacks
>> critical functionality.
>>
>> regards, tom lane
>
> I attached the patch which also update manual as the mention of sawada-san.
>

Thank you for updating the patch. Also maybe we can update line in
PostgresNode.pm where hot_standby is set to on explicitly.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center