Re: [PostgreSQL 10] default of hot_standby should be "on"?

From: Huong Dangminh <huo-dangminh(at)ys(dot)jp(dot)nec(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: Hiroshi Yanagisawa <hir-yanagisawa(at)ut(dot)jp(dot)nec(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PostgreSQL 10] default of hot_standby should be "on"?
Date: 2017-04-27 00:54:19
Message-ID: 75DB81BEEA95B445AE6D576A0A5C9E936A625785@BPXM05GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks all for your comments.

> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > +1. I definitely think we should do it, and 10 would be the time to do
> it.
>
> Agreed. It's mainly a historical accident that the default is what it
> is,
> I think.
>
> > I wonder if we should also consider changing the standby error message
> to
> > be a WARNING instead of an ERROR. So that if you try to start up a standby
> > with hot_standby=on but master with wal_level=replica it would turn into
> a
> > cold standby.
>
> I'm -1 for that: if you fat-finger the configuration, you should be told
> about it, not have the system start up in an unintended mode that lacks
> critical functionality.
>
> regards, tom lane

I attached the patch which also update manual as the mention of sawada-san.

---
Thanks and best regards,
Dang Minh Huong
NEC Solution Innovators, Ltd.
http://www.nec-solutioninnovators.co.jp/en/

Attachment Content-Type Size
hot_standby.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-04-27 00:58:31 Re: Unportable implementation of background worker start
Previous Message Vaishnavi Prabakaran 2017-04-27 00:42:19 Re: [PostgreSQL 10] default of hot_standby should be "on"?