| From: | Kiran Kaki <itskkpg(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views |
| Date: | 2026-08-31 20:21:12 |
| Message-ID: | CAD0dvCQDGVb_n1-39-Udirz4urzSsH0jh7CQagm7wUrnu3B80g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
@Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> look like you
intended to share something, but email body just says hi.
On Mon, Aug 31, 2026, 9:11 AM Bharath Rupireddy <
bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> Hi,
>
> On Sat, Aug 29, 2026 at 1:42 PM Kiran Kaki <itskkpg(at)gmail(dot)com> wrote:
> >
> > Hi Bharath,
> >
> > I verified the change, and it works as intended. The new check is
> appropriately placed before replica identity validation. The error is much
> clearer than the previous "has no identity index" message, and the
> documentation update looks good to me.
> >
> > My only suggestion is to add an automated test as it can help catch any
> future regressions in this behavior.
>
> Thanks for reviewing and verifying the change. I think we can skip the
> test for this one since the change is straightforward and unlikely to
> regress.
>
> --
> Bharath Rupireddy
> Amazon Web Services: https://aws.amazon.com
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kiran Kaki | 2026-08-31 20:31:29 | Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views |
| Previous Message | Sami Imseih | 2026-08-31 20:17:28 | Re: pgstat: Flush some statistics within running transactions, take 2 |