| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Kiran Kaki <itskkpg(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views |
| Date: | 2026-08-31 16:11:39 |
| Message-ID: | CALj2ACUgYCWANVDuVFWs0Ef2dz1T_+5WV1Od50Mx-NGBDmR6Vg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sat, Aug 29, 2026 at 1:42 PM Kiran Kaki <itskkpg(at)gmail(dot)com> wrote:
>
> Hi Bharath,
>
> I verified the change, and it works as intended. The new check is appropriately placed before replica identity validation. The error is much clearer than the previous "has no identity index" message, and the documentation update looks good to me.
>
> My only suggestion is to add an automated test as it can help catch any future regressions in this behavior.
Thanks for reviewing and verifying the change. I think we can skip the
test for this one since the change is straightforward and unlikely to
regress.
--
Bharath Rupireddy
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vitaly Davydov | 2026-08-31 16:18:14 | Re: Deadlock detector fails to activate on a hot standby replica |
| Previous Message | Matthias van de Meent | 2026-08-31 16:08:17 | Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts |