Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views

From: Kiran Kaki <itskkpg(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views
Date: 2026-08-31 20:31:29
Message-ID: CAD0dvCQxMHsxyTCb_5Hb8933az0vH=SqzT0jpjp08gQc10MKxg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Bharath,

Ignore my previous reply. Looks like an issue with the gmail client.

Adding a test should be quick and I can help re-validate as a second eye,
but I would let committer to take a call on this based followed practices.
Otherwise the change is good.

Thanks,
Kiran Kaki.

On Mon, Aug 31, 2026, 1:21 PM Kiran Kaki <itskkpg(at)gmail(dot)com> wrote:

> @Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> look like you
> intended to share something, but email body just says hi.
>
> On Mon, Aug 31, 2026, 9:11 AM Bharath Rupireddy <
> bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
>> Hi,
>>
>> On Sat, Aug 29, 2026 at 1:42 PM Kiran Kaki <itskkpg(at)gmail(dot)com> wrote:
>> >
>> > Hi Bharath,
>> >
>> > I verified the change, and it works as intended. The new check is
>> appropriately placed before replica identity validation. The error is much
>> clearer than the previous "has no identity index" message, and the
>> documentation update looks good to me.
>> >
>> > My only suggestion is to add an automated test as it can help catch
>> any future regressions in this behavior.
>>
>> Thanks for reviewing and verifying the change. I think we can skip the
>> test for this one since the change is straightforward and unlikely to
>> regress.
>>
>> --
>> Bharath Rupireddy
>> Amazon Web Services: https://aws.amazon.com
>>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2026-08-31 20:41:37 Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views
Previous Message Kiran Kaki 2026-08-31 20:21:12 Re: REPACK (CONCURRENTLY) fails with wrong error for materialized views