Re: BUG #19095: Test if function exit() is used fail when linked static

From: VASUKI M <vasukim1992002(at)gmail(dot)com>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, BharatDB <bharatdbpg(at)gmail(dot)com>, torsten(dot)rupp(at)gmx(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: 2026-02-18 04:19:47
Message-ID: CACTYHzg=W-D06q2c8jdNi7r9EA+urDVi0zoGTyrY3Q3eA_9P-A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi Nazir,

Thank you for pointing this out, and thanks to Andres for the clarification
in the referenced thread.

You are absolutely right — with a stamp file, we need to ensure that its
timestamp is updated unconditionally so that it remains newer than the
inputs. Keeping the existence check (if (! -f ...)) would indeed leave the
stamp file older than the rebuilt library, which can trigger unnecessary
rebuilds in Makefile-based builds.

Although Ninja avoids repeated rebuilds due to its internal tracking, Make
relies purely on timestamps, so the safer and correct behavior is to always
recreate (touch) the stamp file.

The updated implementation without the existence check is therefore the
correct approach.

Regards,
Vasuki M
C-DAC,chennai

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2026-02-18 08:19:16 Re: BUG #19095: Test if function exit() is used fail when linked static
Previous Message Richard Guo 2026-02-18 01:51:40 Re: BUG #19412: Wrong query result with not null constraint

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-02-18 04:21:28 Re: index prefetching
Previous Message Michael Paquier 2026-02-18 03:26:53 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart