Re: BUG #19095: Test if function exit() is used fail when linked static

Hi,

On Wed, 10 Dec 2025 at 08:14, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Dec 10, 2025 at 08:11:37AM +0900, Michael Paquier wrote:
> > On Tue, Dec 09, 2025 at 03:47:13PM +0300, Bilal Yavuz wrote:
> >> I agree with both of you. We do the same thing for 'ZIC' binary, so I
> >> think putting it to pgxs_empty is the correct fix.
> >
> > Thanks for double-checking. I was not 100% sure if my analysis was
> > completely right as I was looking at this file for the first time.
>
> On top of the rest, I have double-checked the buildfarm and things
> seem fine with 4a8e6f43a6b5, so the last piece about pthread_exit() is
> now done with 8268e66ac64c.

In another thread [1], Andres pointed out that we need to create a
stamp file again although it exists. Otherwise, the stamp file will be
older than the inputs and it causes rebuilding. In Andres' own words
from [1]:

```
> +sub create_stamp_file
> +{
> + # Avoid touching existing stamp file to prevent unnecessary rebuilds
> + if (!(-f $stamp_file))
> + {
> + open my $fh, '>', $stamp_file
> + or die "can't open $stamp_file: $!";
> + close $fh;
> + }
> +}

Won't that *cause* rebuilds? With a stamp file you normally want the stamp
file to be *newer* than the inputs. Which it won't be, if you don't touch it
here.

The only reason it doesn't cause quick rebuilds with meson is that ninja
remembers the timestamps of files an avoids rebuilds if they haven't changed.
```

Andres is right. We have the same problem on this libpq_check.pl,
attached fixes that.

[1] https://postgr.es/m/nxszznj6nkdj2vh5cxvwzpwodsbtui6mqluxnur2y4x7xtkirw%40fbvhy54mluzl

--
Regards,
Nazir Bilal Yavuz
Microsoft