Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline

From: Xuneng Zhou <xunengzhou(at)gmail(dot)com>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: t/035_standby_logical_decoding.pl might fail on attempt to read wrong timeline
Date: 2026-06-09 06:13:54
Message-ID: CABPTF7UFHTwukHhKQP7u9S7BuyzXvrqq46ZPPoC+T1A4FAoe2Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 9, 2026 at 1:57 PM Bertrand Drouvot
<bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>
> Hi Hayato-san,
>
> On Tue, Jun 09, 2026 at 04:04:20AM +0000, Hayato Kuroda (Fujitsu) wrote:
> > Dear Bertrand, Xuneng,
> >
> > Thanks for sharing the reproducer and opinion. I could now understand.
> >
> > While seeing, I felt the same issue can happen even for the streaming case.
> > Please see attached reproducer and possible fix.

Good catch!

> I just had a quick look and I feel that's probably an issue too (good find!).
> I think that your fix should use GetWALInsertionTimeLineIfSet() though (but I
> only did a quick scan on your patch).
>
> > Can you also include that point? Or this thread discusses only for the logical case?
> > If separated, I can take initiative for the streaming part, after the logical decoding
> > case.
>
> I would says it's probably better to keep this thread focusing on Alexander's issue
> (logical decoding). Once this thread is fixed, then I'd suggest to open a dedicated
> thread for the streaming one (mentioning this thread and probably trying to mimic
> its fix as close as possible).
>

+1 for starting a dedicated thread. Please CC me in that thread in
case I miss it.

--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-06-09 06:22:32 Fix SET EXPRESSION for virtual columns with whole-row dependencies
Previous Message jian he 2026-06-09 06:11:57 Re: typedef struct WindowClause misleading comments