| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_createsubscriber: Fix incorrect handling of cleanup flags |
| Date: | 2026-05-11 01:22:55 |
| Message-ID: | CAHGQGwFRLfw-5502-90_rSRx-vBQFqafEPFfb-oZR+RqbwdOqg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, May 10, 2026 at 1:30 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Wed, Apr 1, 2026 at 1:44 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > The patch needed rebasing after recent changes in pg_createsubscriber
> > under commit d6628a5.
> > Please find the rebased patch (v3) attached.
> >
>
> Needed a rebase after recent commits. Attached the rebased v4 patch.
Thanks for updating the patch! It looks good to me.
We can remove the third argument, made_publication, from drop_publication()
since it is no longer used?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2026-05-11 01:40:13 | Re: Proposal: tighten validation for legacy EUC encodings or document that accepted byte sequences may be unconvertible to UTF8 |
| Previous Message | Alexander Korotkov | 2026-05-10 23:42:51 | Re: Dump statistic issue with index on expressions |