Re: Remove Deprecated Exclusive Backup Mode

On Fri, Dec 21, 2018 at 5:43 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Fri, Dec 21, 2018 at 1:18 AM David Steele <david(at)pgmasters(dot)net> wrote:
> > On 12/21/18 2:01 AM, Michael Paquier wrote:
> > > On Thu, Dec 20, 2018 at 12:29:48PM +0200, David Steele wrote:
> > >> Cannot move patch to the same commitfest, and multiple future
> commitfests
> > >> exist!
> > >
> > > I am not sure what it means either. What if you just mark the existing
> > > entry as returned with feedback, and create a new one ahead?
> >
> > Yeah, I can do that, but it would be nice to know why this is not
> > working. It would also be nice to preserve the history.
> >
> > Magnus?
>
> I think what it means is that it doesn't know which CommitFest is the
> "next" one. If the patch were currently in the in-progress
> CommitFest, the Open one (if any) would be the next one. Otherwise,
> if there were only one Future CommitFest, that would be the next one.
> But right now you're moving a patch that is already in the Open
> CommitFest and there are two 2 Future CommitFests, so it doesn't know
> which one to pick.
>
> I think the old CommitFest application let you set the CommitFest via
> the Edit screen also, so you could pick a specific CommitFest to
> target. But that doesn't seem to exist in Magnus's version.
>

That was a specifically requested change, and IIRC has been discussed
before whenever people run into it :)

The basics is, there is not supposed to be more than one Future commitfest,
in order to keep the workflow as simple as possible. When there is, all
sorts of bad things happen. What we really should have at that point is a
blocker so you can't *create* more than one of them, but right now it
naively assumes nobody does...

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>