Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document

From: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document
Date: 2026-07-30 01:27:32
Message-ID: CAB8KJ=i3ouPKdOPqXF2y37F-znzn88q9SkQdzeNXbNpTY5tuQg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2026年7月29日(水) 19:50 Daniel Gustafsson <daniel(at)yesql(dot)se>:
>
> > On 27 Jul 2026, at 20:10, surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
> > +1 for documenting it.
>
> Pushed.

Thanks!

> > It might also be worth mentioning in the description that this returns the server encoding, i.e. the same value as current_setting('server_encoding').
> > Feel free to ignore if you'd rather keep the entry minimal.
>
> That could be applied in many places, so I opted out of doing in this single
> instance and instead went with consistency with the client encoding function.

Yup, if at all that would be a separate operation.

Regards

Ian Barwick

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-07-30 01:59:10 Re: PSQL schema "describe" \dn is not escaping quotes
Previous Message Christophe Pettus 2026-07-30 01:26:54 Re: [PATCH v2] Don't stop a `vacuumdb --all` on a connection failure