Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: surya poondla <suryapoondla4(at)gmail(dot)com>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thom Brown <thom(at)linux(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] Rename "getdatabaseencoding()" to "pg_database_encoding()", and document
Date: 2026-07-29 10:50:23
Message-ID: 1F36EE6F-D130-4D36-A106-E351C642C1EA@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 27 Jul 2026, at 20:10, surya poondla <suryapoondla4(at)gmail(dot)com> wrote:

> +1 for documenting it.

Pushed.

> It might also be worth mentioning in the description that this returns the server encoding, i.e. the same value as current_setting('server_encoding').
> Feel free to ignore if you'd rather keep the entry minimal.

That could be applied in many places, so I opted out of doing in this single
instance and instead went with consistency with the client encoding function.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Andrey Rachitskiy 2026-07-29 10:36:45 Re: Build warning with meson and dtrace on Fedora 43