Re: Is postgresql on Windows compatible with flex 2.6.0?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Is postgresql on Windows compatible with flex 2.6.0?
Date: 2015-12-10 12:19:46
Message-ID: CAB7nPqTQedPSNFLOZogq3fvFnEfjEgg0_GLX67fuPdxf-uY1oA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 10, 2015 at 5:45 PM, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> wrote:
> Recently (about a month ago) flex 2.6.0 have been released.
>
> But when we tried to compile PostgreSQL 9.5 beta 1 from git with it on
> Windows, we've encountered that src/tools/msvc/pgflex.pl explicitely
> checks that minor version of flex is equal to 5.
>
> unless ($verparts[0] == 2 && $verparts[1] == 5 && $verparts[2]
> >=31) { print "WARNING! Flex install not found, or unsupported Flex
> version.\n"; print "echo Attempting to build without.\n";
> exit 0;
> }
>
> Is this check intentional, or it just seats here from the time when
> version 2.6.0 didn't exist?
>
> Postgres seems to compile fine with flex 2.6.0.

It seems that 32f15d05 missed to update its equivalent in
src/tools/msvc. Per se the patch attached as you already found out.
--
Michael

Attachment Content-Type Size
20151210_msvc_flex.patch binary/octet-stream 627 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-10 12:20:57 Re: Error with index on unlogged table
Previous Message Andres Freund 2015-12-10 12:13:18 Re: Error with index on unlogged table