Re: moving from contrib to bin

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: moving from contrib to bin
Date: 2015-03-10 23:45:36
Message-ID: CAB7nPqTALhottF2QVL88B7HUEDeUOah--bEK2+g1+Xu4AdRBeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 10, 2015 at 10:48 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Andres Freund wrote:
>
>> Rebased (fair amount of trivial conflicts due to the copyright year
>> bump) and attached as -MC style format-patch. If you look at the content
>> of the patches you can see that the diff makes more sense now.
>
> Ah --- I just realized that the change Peter is proposing from backslash
> to forward slashes in the MSVC build stuff is related to testability of
> this patch set in non-Windows environments. Can we get that patch done
> please? It seems there's only a small bit missing there.
>
> How do we go about getting these patches pushed?

I think that one of the last point raised (by Andres) was if the
Makefiles in src/bin should depend on pgxs.mk or not. FWIW, I think as
well that it should be a subsequent patch not related to this one as
it is a different debate to have stuff of src/bin depend on contrib
infrastructure.

Now, the pushing plan was to have the stuff of pg_upgrade done in a
separate commit. Note that I am fine helping out wrapping up things
particularly on Windows if that helps.

> Note that each utility we move to src/bin will create a new translatable
> module for 9.5. It would be better to do it soon rather than waiting at
> the very end of the cycle, so that translators have time to work through
> the bunch of extra files.

That's a point.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-03-11 01:06:37 Re: moving from contrib to bin
Previous Message Tom Lane 2015-03-10 23:24:40 Re: Rethinking the parameter access hooks for plpgsql's benefit