Re: moving from contrib to bin

Michael Paquier wrote:
> On Tue, Mar 10, 2015 at 10:48 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:

> > How do we go about getting these patches pushed?
>
> I think that one of the last point raised (by Andres) was if the
> Makefiles in src/bin should depend on pgxs.mk or not. FWIW, I think as
> well that it should be a subsequent patch not related to this one as
> it is a different debate to have stuff of src/bin depend on contrib
> infrastructure.

I don't think we care one bit whether these modules use pgxs, at least
not currently. If we find any issues later on, it should be an easy fix
anyway.

> Now, the pushing plan was to have the stuff of pg_upgrade done in a
> separate commit. Note that I am fine helping out wrapping up things
> particularly on Windows if that helps.

I vote for moving one module per commmit. Probably the first commit
will be the hardest one to get right, so let's pick an easy module --
say, pgbench. That way there are less gotchas hopefully. Once we have
that working everywhere we look into moving another one.

> > Note that each utility we move to src/bin will create a new translatable
> > module for 9.5. It would be better to do it soon rather than waiting at
> > the very end of the cycle, so that translators have time to work through
> > the bunch of extra files.
>
> That's a point.

I'm a translator ;-)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services