Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Wong, Yi Wen" <yiwong(at)amazon(dot)com>, "Wood, Dan" <hexpert(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Date: 2017-10-10 01:00:10
Message-ID: CAB7nPqSrXiFEkv7Ug8jSmAuH-4tF65pPYATb-J1PzB5KAP86DA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Oct 9, 2017 at 2:29 AM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> On Sat, Oct 7, 2017 at 4:25 PM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>> Hmm, I think I added a random sleep (max. 100ms) right after the
>> HeapTupleSatisfiesVacuum call in vacuumlazy.c (lazy_scan_heap), and that
>> makes the race easier to hit.
>
> I still cannot reproduce. Perhaps you can be more specific?

I have been trying to reproduce things for a total of 4 hours, testing
various variations of the proposed test cases (killed Postgres,
changed fillfactor, manual sleep calls), but I am proving unable to
see a regression as well. I would not think that the OS matters here,
all my attempts were on macos with assertions and debugging enabled.

At least the code is now more stable, which is definitely a good thing.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-10-10 03:33:36 Re: pgsql: Add pg_strnlen() a portable implementation of strlen.
Previous Message Andres Freund 2017-10-09 23:15:09 Re: pgsql: Add pg_strnlen() a portable implementation of strlen.

Browse pgsql-hackers by date

  From Date Subject
Next Message Stas Kelvich 2017-10-10 01:19:17 Re: Issues with logical replication
Previous Message Fabrízio de Royes Mello 2017-10-10 00:45:23 Re: search path security issue?