From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add pg_strnlen() a portable implementation of strlen. |
Date: | 2017-10-10 03:33:36 |
Message-ID: | 44745881-6095-e3ba-e8eb-23b1d92bffab@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 10/09/2017 07:15 PM, Andres Freund wrote:
> Hi Andrew,
>
> On 2017-10-09 22:22:04 +0000, Andres Freund wrote:
>> Add pg_strnlen() a portable implementation of strlen.
>>
>> As the OS version is likely going to be more optimized, fall back to
>> it if available, as detected by configure.
> I'm a bit confused, frogmouth
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2017-10-09%2022%3A30%3A41
> shows that it compiled the new code, but the configure output doesn't
> show it ran through the new configure test. Additionally, without the
> the config define, this should result in the replacement being
> used. Which doesn't seem to be the case either.
>
> Kinda sounds like this used some halfway outdated build or such?
>
frogmouth is using some code not yet released that makes the config
cache persistent. I just identified and fixed a stupid bug in the code
that obsoletes the cache, and I have removed frogmouth's cache file and
set it running again, so we'll see if that fixes things.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2017-10-10 04:25:52 | Re: pgsql: Add pg_strnlen() a portable implementation of strlen. |
Previous Message | Michael Paquier | 2017-10-10 01:00:10 | Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple |