Re: pgsql: Add pg_strnlen() a portable implementation of strlen.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: Add pg_strnlen() a portable implementation of strlen.
Date: 2017-10-09 23:15:09
Message-ID: 20171009231509.nlptgdrtg2au6frn@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Andrew,

On 2017-10-09 22:22:04 +0000, Andres Freund wrote:
> Add pg_strnlen() a portable implementation of strlen.
>
> As the OS version is likely going to be more optimized, fall back to
> it if available, as detected by configure.

I'm a bit confused, frogmouth
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2017-10-09%2022%3A30%3A41
shows that it compiled the new code, but the configure output doesn't
show it ran through the new configure test. Additionally, without the
the config define, this should result in the replacement being
used. Which doesn't seem to be the case either.

Kinda sounds like this used some halfway outdated build or such?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-10-10 01:00:10 Re: [COMMITTERS] pgsql: Fix freezing of a dead HOT-updated tuple
Previous Message Andres Freund 2017-10-09 22:22:04 pgsql: Fix pnstrdup() to not memcpy() the maximum allowed length.