Re: Wrong definition of pgwin32_bind.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Wrong definition of pgwin32_bind.
Date: 2016-04-14 12:08:24
Message-ID: CAB7nPqSov2QSfrVsPEKe-TDik5Bk_gPayLaxfy7ntz5Odi-7iQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 14, 2016 at 5:15 PM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hello.
>
> VC complains that pgwin32_bind() had a parameter differs in
> levels of indirection from definition. pgwin32_bind() in
> src/backend/port/win32/socket.c is defined as the following.
>
>> int pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);
>
> The third parameter should be int, not int*. It might have been
> confused with pgwin32_accept.
>
> The attached patch fixes this.

Nice catch.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-04-14 12:26:18 Re: SEGFAULT in CREATE EXTENSION related pg_init_privs
Previous Message Daniel Verite 2016-04-14 12:08:02 Re: \crosstabview fixes