| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Wrong definition of pgwin32_bind. |
| Date: | 2016-04-14 08:15:35 |
| Message-ID: | 20160414.171535.27292694.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
VC complains that pgwin32_bind() had a parameter differs in
levels of indirection from definition. pgwin32_bind() in
src/backend/port/win32/socket.c is defined as the following.
> int pgwin32_bind(SOCKET s, struct sockaddr * addr, int *addrlen);
The third parameter should be int, not int*. It might have been
confused with pgwin32_accept.
The attached patch fixes this.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_pgwin32_bind_definition.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2016-04-14 08:17:43 | Re: [COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys. |
| Previous Message | Ashutosh Sharma | 2016-04-14 08:13:34 | pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location |