| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Tatsuo Ishii <ishii(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fun with "Ready for Committer" patches |
| Date: | 2016-03-09 21:23:07 |
| Message-ID: | CAB7nPqSGxUWd0+9DtnT97eQA3jOjEuJ4M_qTQb3uqe6nA=4sFg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 9, 2016 at 10:19 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-03-10 06:14:25 +0900, Michael Paquier wrote:
>> IMO, during a review one needs to think of himself as a committer.
>> Once the reviewer switches the patch to "Ready for committer", it
>> means that the last version of the patch present would have been the
>> version that gained the right to be pushed.
>
> And one consideration there is whether you, as the committer, would be
> ok with maintaining this feature going forward.
Yes, that's a key point. Committers do the initial push and the
after-sales service as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-03-09 21:30:44 | Re: TAP / recovery-test fs-level backups, psql enhancements etc |
| Previous Message | Andres Freund | 2016-03-09 21:19:29 | Re: fun with "Ready for Committer" patches |