Re: pgsql: Refactor Perl test code

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Refactor Perl test code
Date: 2015-12-03 00:20:05
Message-ID: CAB7nPqSFPhDJTM6B5uxDRK5vFmuK2vzwgG5ONXXkSs8HW3=Htg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote:
> Test Summary Report
> -------------------
> t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0)
> Non-zero exit status: 25
> Parse errors: Bad plan. You planned 14 tests but ran 8.
> Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.01 csys = 0.11 CPU)
> Result: FAIL
> make[2]: *** [check] Error 1
> make[2]: Leaving directory `/home/postgres/pgsql/src/bin/initdb'
> make[1]: *** [check-initdb-recurse] Error 2
> make[1]: Leaving directory `/home/postgres/pgsql/src/bin'
> make: *** [check-world-src/bin-recurse] Error 2
>
> The buildfarm looks pretty unhappy too, though I've not checked to see if
> it's exactly the same symptom everywhere.

Or in more details:
Undefined subroutine &TestLib::run called at
/Users/mpaquier/git/postgres/src/bin/initdb/../../../src/test/perl/TestLib.pm
line 146.
I am seeing the same failure on all the machines in the buildfarm.

The issue is fixed by the patch attached. This has been visibly
forgotten in the version pushed.
Regards,
--
Michael

Attachment Content-Type Size
20151203_tap_fix.patch text/x-patch 333 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2015-12-03 02:16:55 pgsql: Fix broken subroutine call in TestLib
Previous Message Tom Lane 2015-12-02 23:38:15 Re: pgsql: Refactor Perl test code

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-03 00:22:39 Re: snapshot too old, configured by time
Previous Message Julien Rouhaud 2015-12-03 00:08:22 Re: Postgres_FDW optimizations