Re: pgsql: Refactor Perl test code

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Refactor Perl test code

This has broken "make check-world" for me (on RHEL 6.7):

make -C src/bin check
make[1]: Entering directory `/home/postgres/pgsql/src/bin'
make -C initdb check
make[2]: Entering directory `/home/postgres/pgsql/src/bin/initdb'
rm -rf /home/postgres/pgsql/src/bin/initdb/tmp_check/log
cd . && TESTDIR='/home/postgres/pgsql/src/bin/initdb' PATH="/home/postgres/pgsql/tmp_install/home/postgres/testversion/bin:$PATH" LD_LIBRARY_PATH="/home/postgres/pgsql/tmp_install/home/postgres/testversion/lib" PGPORT='65440' PG_REGRESS='/home/postgres/pgsql/src/bin/initdb/../../../src/test/regress/pg_regress' prove -I ../../../src/test/perl/ --verbose t/*.pl
t/001_initdb.pl ..
1..14
ok 1 - initdb --help exit code 0
ok 2 - initdb --help goes to stdout
ok 3 - initdb --help nothing to stderr
ok 4 - initdb --version exit code 0
ok 5 - initdb --version goes to stdout
ok 6 - initdb --version nothing to stderr
ok 7 - initdb with invalid option nonzero exit code
ok 8 - initdb with invalid option prints error message
# Looks like you planned 14 tests but ran 8.
# Looks like your test exited with 25 just after 8.
Dubious, test returned 25 (wstat 6400, 0x1900)
Failed 6/14 subtests

Test Summary Report
-------------------
t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0)
Non-zero exit status: 25
Parse errors: Bad plan. You planned 14 tests but ran 8.
Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.01 csys = 0.11 CPU)
Result: FAIL
make[2]: *** [check] Error 1
make[2]: Leaving directory `/home/postgres/pgsql/src/bin/initdb'
make[1]: *** [check-initdb-recurse] Error 2
make[1]: Leaving directory `/home/postgres/pgsql/src/bin'
make: *** [check-world-src/bin-recurse] Error 2

The buildfarm looks pretty unhappy too, though I've not checked to see if
it's exactly the same symptom everywhere.

regards, tom lane