Re: [COMMITTERS] pgsql: Refactor Perl test code

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Thu, Dec 3, 2015 at 8:38 AM, Tom Lane wrote:
>> Test Summary Report
>> -------------------
>> t/001_initdb.pl (Wstat: 6400 Tests: 8 Failed: 0)
>> Non-zero exit status: 25
>> Parse errors: Bad plan. You planned 14 tests but ran 8.
>> Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.08 cusr 0.01 csys = 0.11 CPU)
>> Result: FAIL
>> make[2]: *** [check] Error 1
>> make[2]: Leaving directory `/home/postgres/pgsql/src/bin/initdb'
>> make[1]: *** [check-initdb-recurse] Error 2
>> make[1]: Leaving directory `/home/postgres/pgsql/src/bin'
>> make: *** [check-world-src/bin-recurse] Error 2
>>
>> The buildfarm looks pretty unhappy too, though I've not checked to see if
>> it's exactly the same symptom everywhere.

> Or in more details:
> Undefined subroutine &TestLib::run called at
> /Users/mpaquier/git/postgres/src/bin/initdb/../../../src/test/perl/TestLib.pm
> line 146.

BTW, not the fault of this patch in particular, but this example points
up the complaint I've had right along about how opaque TAP test failures
are. How did you dig down to see that error message? Is it even possible
to diagnose such a failure from what the buildfarm logs?

regards, tom lane