Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel
Date: 2015-06-30 12:53:07
Message-ID: CAB7nPqSCwCWyAt5bFdOmBVUXU6qzmzcAcWgRmd3O-=B-tVLQBg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
is doing a NULL-pointer check for something that has been dereferenced
on all the code paths leading to this check.
(Yes, that's not interesting for common humans, Coverity sees things
based on correctness).

Regards,
--
Michael

Attachment Content-Type Size
20150630_freespace_ptrcheck.patch text/x-patch 536 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-06-30 12:57:07 Re: Missing checks on return value of timestamp2tm in datetime.c
Previous Message Michael Paquier 2015-06-30 12:45:19 Missing checks on return value of timestamp2tm in datetime.c