Missing checks on return value of timestamp2tm in datetime.c

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Missing checks on return value of timestamp2tm in datetime.c
Date: 2015-06-30 12:45:19
Message-ID: CAB7nPqRSk=J8eUdd55fL-w+k=8sDTHLVBt-cgG9jWN=VO2ogBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

timestamp2tm is called close to 40 times in the backend source code,
returning -1 in case of failure. However, there are two places in
datetime.c where we do not check for its return value: GetCurrentDateTime
and GetCurrentTimeUsec.
This does not really matter much in practice as the timestamp used is
GetCurrentTransactionStartTimestamp(), but for correctness shouldn't we
check for its return code and report ERRCODE_DATETIME_VALUE_OUT_OF_RANGE on
error?

Per se the patch attached.
Regards,
--
Michael

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-06-30 12:53:07 Unneeded NULL-pointer check in FreeSpaceMapTruncateRel
Previous Message Petr Jelinek 2015-06-30 12:23:05 Re: Dereferenced pointer in tablesample.c