Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unneeded NULL-pointer check in FreeSpaceMapTruncateRel
Date: 2015-06-30 12:57:26
Message-ID: 20150630125726.GU30708@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2015-06-30 21:53:07 +0900, Michael Paquier wrote:
> In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel
> is doing a NULL-pointer check for something that has been dereferenced
> on all the code paths leading to this check.
> (Yes, that's not interesting for common humans, Coverity sees things
> based on correctness).

Can you, in the future, batch these together into one thread, perhaps
with one message below an introductory one for each patch? Unless
they'll get applied immediately it'll be hard to follow the different
threads.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-06-30 13:04:26 Re: Exposing PG_VERSION_NUM in pg_config
Previous Message Michael Paquier 2015-06-30 12:57:07 Re: Missing checks on return value of timestamp2tm in datetime.c