| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logical Decoding follows timelines |
| Date: | 2015-02-13 07:57:11 |
| Message-ID: | CAB7nPqS28_Mfj+JzOLuEJVSZNbhyVUnT9q+ULOcQXXGEvB1NVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 17, 2014 at 5:35 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 16 December 2014 at 21:17, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>
> >>> This patch is a WIP version of doing that, but only currently attempts
>
> >> With the patch, XLogSendLogical uses the same logic to calculate
> SendRqstPtr
> >> that XLogSendPhysical does. It would be good to refactor that into a
> common
> >> function, rather than copy-paste.
> >
> > Some of the logic is similar, but not all.
> >
> >> SendRqstPtr isn't actually used for anything in XLogSendLogical.
> >
> > It exists to allow the call which resets TLI.
> >
> > I'll see if I can make it exactly identical; I didn't think so when I
> > first looked, will look again.
>
> Yes, that works. New version attached
>
Moved patch to CF 2015-02 to not lose track of it, also because it does not
seem it received a proper review.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2015-02-13 07:57:55 | Re: Patch to support SEMI and ANTI join removal |
| Previous Message | Michael Paquier | 2015-02-13 07:55:28 | Re: PATCH: hashjoin - gracefully increasing NTUP_PER_BUCKET instead of batching |