| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [doc fix] PG10: wroing description on connect_timeout when multiple hosts are specified |
| Date: | 2017-05-17 00:52:47 |
| Message-ID: | CAB7nPqS=W3q+9ZWipjCV0HVqwXPdhtQiOxy3KVpxgp8sGOHFSA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 17, 2017 at 12:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, May 15, 2017 at 9:59 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> + *
>> + * Returns -1 on failure, 0 if the socket is readable/writable, 1 if
>> it timed out.
>> */
>> pqWait is internal to libpq, so we are free to set up what we want
>> here. Still I think that we should be consistent with what
>> pqSocketCheck returns:
>> * >0 means that the socket is readable/writable, counting things.
>> * 0 is for timeout.
>> * -1 on failure.
>
> That would imply a lot more change, though. The way that the patch
> currently does it, none of the other callers of pqWait() or
> pqWaitTimed() need to be adjusted. So I prefer the way that Tsunakawa
> Takayuki currently has this over your proposal.
Consistency in APIs matters, but I won't fight hard in favor of this
item either. In short I am fine to discard this comment.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2017-05-17 00:54:14 | Re: PG10 pgindent run |
| Previous Message | Tom Lane | 2017-05-17 00:39:36 | Re: PG10 pgindent run |