| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG10 pgindent run |
| Date: | 2017-05-17 00:54:14 |
| Message-ID: | 65470a04-2472-9eea-58f6-1d6468bc690f@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/16/2017 08:39 PM, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> There we go:
>> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=calliphoridae&dt=2017-05-16%2023:16:53&stg=typedefs
> Yup, looks good now. Thanks!
>
> BTW, comparing the typedef list to what I got a few hours ago, I see
> that "Function" is now a known type name, along with the UWhatever
> symbols from ICU. I wonder where that came from? A quick grep
> suggests that it's not going to mess anything up too badly, but it
> sure seems like a poor choice for a globally visible typedef name.
>
>
There is a place in pgindent around line 139 where we filter out
typedefs we don't want. You could add it there of you were so inclined.
I agree this seems like a remarkably bad choice of name.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2017-05-17 01:00:38 | Re: PG10 pgindent run |
| Previous Message | Michael Paquier | 2017-05-17 00:52:47 | Re: Re: [doc fix] PG10: wroing description on connect_timeout when multiple hosts are specified |