| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [doc fix] PG10: wroing description on connect_timeout when multiple hosts are specified |
| Date: | 2017-05-16 15:47:42 |
| Message-ID: | CA+TgmoYS+io6zFu6xFs2PzFz1qm06yZwqxOacKhohpW2K4nYKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 15, 2017 at 9:59 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> + *
> + * Returns -1 on failure, 0 if the socket is readable/writable, 1 if
> it timed out.
> */
> pqWait is internal to libpq, so we are free to set up what we want
> here. Still I think that we should be consistent with what
> pqSocketCheck returns:
> * >0 means that the socket is readable/writable, counting things.
> * 0 is for timeout.
> * -1 on failure.
That would imply a lot more change, though. The way that the patch
currently does it, none of the other callers of pqWait() or
pqWaitTimed() need to be adjusted. So I prefer the way that Tsunakawa
Takayuki currently has this over your proposal.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-05-16 15:54:16 | Re: Patch to fix documentation about AFTER triggers |
| Previous Message | Robert Haas | 2017-05-16 15:31:34 | Re: Adding support for Default partition in partitioning |