| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Date: | 2016-10-25 05:52:34 |
| Message-ID: | CAB7nPqREHC-Lt_wJ9YdXmK18kOXMCsJpicobYAqdainaHgBNPA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Oct 25, 2016 at 1:17 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Well... Coming back to the subject, are there any recommendations from
>> committers? -std=c89 in CFLAGS does not seem to help much to detect
>> extra commas in enums, even if this has been added in C99.
>
> My opinion is don't worry about it. The buildfarm will find such problems
> just fine, and there's no functional reason to stress about finding
> extra commas before that.
Thanks for the feedback. Alea jacta est.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2016-10-25 14:26:00 | Re: pgsql: Use OpenSSL EVP API for symmetric encryption in pgcrypto. |
| Previous Message | Tom Lane | 2016-10-25 04:17:37 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2016-10-25 05:59:15 | Re: Minor code improvement to postgresGetForeignJoinPaths |
| Previous Message | Haribabu Kommi | 2016-10-25 05:38:56 | Re: macaddr 64 bit (EUI-64) datatype support |