Re: Minor code improvement to postgresGetForeignJoinPaths

From: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor code improvement to postgresGetForeignJoinPaths
Date: 2016-10-25 05:59:15
Message-ID: 580EF4B3.9090107@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ashutosh,

> You are right. Every call except that one is using NIL, so better to
> fix it. The pattern was repeated in the recent aggregate pushdown
> support. Here's patch to fix create_foreignscan_path() call in
> add_foreign_grouping_paths() as well.

Thanks for the review!

Tatsuro Yamada
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-10-25 06:00:47 Re: pg_hba_file_settings view patch
Previous Message Michael Paquier 2016-10-25 05:52:34 Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list