| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Date: | 2016-10-25 04:17:37 |
| Message-ID: | 17469.1477369057@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Well... Coming back to the subject, are there any recommendations from
> committers? -std=c89 in CFLAGS does not seem to help much to detect
> extra commas in enums, even if this has been added in C99.
My opinion is don't worry about it. The buildfarm will find such problems
just fine, and there's no functional reason to stress about finding
extra commas before that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-10-25 05:52:34 | Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list |
| Previous Message | Robert Haas | 2016-10-25 02:39:23 | pgsql: postgres_fdw: Try again to stabilize aggregate pushdown regressi |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2016-10-25 05:38:56 | Re: macaddr 64 bit (EUI-64) datatype support |
| Previous Message | Amit Kapila | 2016-10-25 04:10:09 | Re: Speed up Clog Access by increasing CLOG buffers |