| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Martín Marqués <martin(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump with tables created in schemas created by extensions |
| Date: | 2016-08-30 05:02:43 |
| Message-ID: | CAB7nPqQjmN6JRJ9o3QH3Lpz24X3Kb3x_w4i4fG+shVhbi-6MEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 30, 2016 at 5:43 AM, Martín Marqués <martin(at)2ndquadrant(dot)com> wrote:
> This is v4 of the patch, which is actually a cleaner version from the
> v2 one Michael sent.
>
> I stripped off the external index created from the tests as that index
> shouldn't be dumped (table it belongs to isn't dumped, so neither
> should the index). I also took off a test which was duplicated.
>
> I think this patch is a very good first approach. Future improvements
> can be made for indexes, but we need to get the extension dependencies
> right first. That could be done later, on a different patch.
>
> Thoughts?
Let's do as you suggest then, and just focus on the schema issue. I
just had an extra look at the patch and it looks fine to me. So the
patch is now switched as ready for committer.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | K S, Sandhya (Nokia - IN/Bangalore) | 2016-08-30 05:48:47 | Postgres abort found in 9.3.11 |
| Previous Message | Michael Paquier | 2016-08-30 04:52:25 | Re: Re: [sqlsmith] FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)", File: "xlog.c", Line: 10200) |