Re: pg_dump with tables created in schemas created by extensions

From: Martín Marqués <martin(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump with tables created in schemas created by extensions
Date: 2016-08-30 08:37:41
Message-ID: CAPdiE1w29BTpRMycG+z0Cv=2in5TdzQtRx3DeQ9Vugu=4GH5XA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2016-08-30 2:02 GMT-03:00 Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:
> On Tue, Aug 30, 2016 at 5:43 AM, Martín Marqués <martin(at)2ndquadrant(dot)com> wrote:
>> This is v4 of the patch, which is actually a cleaner version from the
>> v2 one Michael sent.
>>
>> I stripped off the external index created from the tests as that index
>> shouldn't be dumped (table it belongs to isn't dumped, so neither
>> should the index). I also took off a test which was duplicated.
>>
>> I think this patch is a very good first approach. Future improvements
>> can be made for indexes, but we need to get the extension dependencies
>> right first. That could be done later, on a different patch.
>>
>> Thoughts?
>
> Let's do as you suggest then, and just focus on the schema issue. I
> just had an extra look at the patch and it looks fine to me. So the
> patch is now switched as ready for committer.

That's great. Thanks for all Michael

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Devrim Gündüz 2016-08-30 09:09:34 9.5.4: Segfault (signal 11) while running ALTER TABLE
Previous Message Maksim Milyutin 2016-08-30 08:22:43 Re: [WIP] Patches to enable extraction state of query execution from external session