From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | John Harvey <john(dot)harvey(at)crunchydata(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: MSVC pl-perl error message is not verbose enough |
Date: | 2016-07-27 01:44:55 |
Message-ID: | CAB7nPqQJ_x=HtVRx7xFLb20y7HVJaSoywBVuHCkXtXc1xOGMaQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 27, 2016 at 12:41 AM, John Harvey
<john(dot)harvey(at)crunchydata(dot)com> wrote:
> Because of this, I've submitted a small patch which fixes the verbosity of
> the error message to actually explain what's missing. I hope that this
> patch will be considered for the community, and it would be nice if it was
> back-patched.
Improving this error message a bit looks like a good idea to me.
Looking at the code to figure out what build.pl is looking for is a
bit a pain for users just willing to compile the code, so if we can
avoid such lookups with a cheap way, let's do it.
Instead of your patch, I'd suggest saving $solution->{options}->{perl}
. '\lib\CORE\perl*.lib' in a variable and then raise an error based on
that. See attached.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
msvc_pl_perl_error_verbose_v2.patch | application/x-patch | 734 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-07-27 02:03:07 | Re: No longer possible to query catalogs for index capabilities? |
Previous Message | Tom Lane | 2016-07-27 01:41:28 | Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE |