From: | John Harvey <john(dot)harvey(at)crunchydata(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: MSVC pl-perl error message is not verbose enough |
Date: | 2016-07-27 12:58:25 |
Message-ID: | CABcP5fjWJoDb43HByH3xm4dWwaiLq6bBUawL3nM7zdzdkcLLLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jul 26, 2016 at 9:44 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> On Wed, Jul 27, 2016 at 12:41 AM, John Harvey
> <john(dot)harvey(at)crunchydata(dot)com> wrote:
> > Because of this, I've submitted a small patch which fixes the verbosity
> of
> > the error message to actually explain what's missing. I hope that this
> > patch will be considered for the community, and it would be nice if it
> was
> > back-patched.
>
> Improving this error message a bit looks like a good idea to me.
> Looking at the code to figure out what build.pl is looking for is a
> bit a pain for users just willing to compile the code, so if we can
> avoid such lookups with a cheap way, let's do it.
>
> Instead of your patch, I'd suggest saving $solution->{options}->{perl}
> . '\lib\CORE\perl*.lib' in a variable and then raise an error based on
> that. See attached.
Looks good to me. I think this is a cleaner approach.
I've just verified that it works correctly, so I'm happy with it.
-John
From | Date | Subject | |
---|---|---|---|
Next Message | Vik Fearing | 2016-07-27 12:59:17 | Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE |
Previous Message | Vik Fearing | 2016-07-27 12:52:54 | Re: Why we lost Uber as a user |