From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
Date: | 2017-08-30 23:39:18 |
Message-ID: | 20170830233918.4f6oakae5xrk2h5a@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Michael Paquier wrote:
> On Tue, Aug 29, 2017 at 11:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> >> I don't like breaking the abstraction of pg_log() with the existing
> >> flags with some kind of pg_debug() layer. The set of APIs present now
> >> in pg_rewind for logging is nice to have, and I think that those debug
> >> messages should be translated. So what about the attached?
> >
> > Your point about INT64_FORMAT not necessarily working with fprintf
> > is an outstanding reason not to keep it like it is. I've not reviewed
> > this patch in detail but I think this is basically the way to fix it.
>
> So, perhaps it would be better to fix that before the next point release?
Sure, I'll get it done on Friday, or tomorrow if I can manage it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-08-30 23:50:54 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
Previous Message | Michael Paquier | 2017-08-30 22:16:59 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-08-30 23:50:54 | Re: Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB. |
Previous Message | David G. Johnston | 2017-08-30 23:35:10 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |