Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Date: 2025-11-23 22:52:21
Message-ID: CAApHDvr7HHo5kfcCNX9YFDD3ogugB8V6JjXUSas+RrNwwbZs7A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> struct comments fail to express this, it says:
>
> indexkeys[], indexcollations[] each have ncolumns entries.
>
> So we should polish this description. trivial patch attached.

Thanks. I agree with the patch. We should probably mention
canreturn[] too. I can take care of this.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-11-23 23:03:53 Re: PRI?64 vs Visual Studio (2022)
Previous Message Greg Burd 2025-11-23 21:17:25 Re: Trying out <stdatomic.h>