Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

From: Junwang Zhao <zhjwpku(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Date: 2025-11-24 01:57:03
Message-ID: CAEG8a3KWE9bdOaVVrD22HtF93QTG27vdqfJ=BxEMCFKb1R_eUQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku(at)gmail(dot)com> wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> > So we should polish this description. trivial patch attached.
>
> Thanks. I agree with the patch. We should probably mention
> canreturn[] too. I can take care of this.

Agreed. Thanks for taking care of this.

>
> David

--
Regards
Junwang Zhao

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2025-11-24 02:31:14 Re: SQL Property Graph Queries (SQL/PGQ)
Previous Message Chao Li 2025-11-24 00:59:57 Re: Row pattern recognition