Re: PRI?64 vs Visual Studio (2022)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: PRI?64 vs Visual Studio (2022)
Date: 2025-11-23 23:03:53
Message-ID: CA+hUKG+BpW=KhGHTWGMe0cSETMYZsSygv5jFWD1Y6wcbAn2ecQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 23, 2025 at 4:25 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > That'd leave only Cygwin with HAVE BUGGY_STRTOF. Perhaps they have
> > fixed their implementation[1]? Here's an experimental patch to drop
> > all remnants, which could be used to find out. No Windows/Cygwin
> > here. Hmm, what if we just commit it anyway? If their strtof() is
> > still broken and someone out there is running the tests and sees this
> > test fail, why shouldn't they take that up with libc at this stage?
>
> Hmm, we could get rid of the whole resultmap mechanism ...

Yeah. I thought I'd see what blowback my
if-Cygwin-strtof()-really-is-still-broken-they-should-fix-it argument
attracted before spending the time to nuke all those lines too.
Here's that patch. We could always revert resultmap we found a new
reason to need it, but I hope we wouldn't.

Attachment Content-Type Size
v2-0001-Drop-HAVE_BUGGY_STRTOF-for-MinGW.patch text/x-patch 4.5 KB
v2-0002-Drop-HAVE_BUGGY_STRTOF-for-Cygwin.patch text/x-patch 44.9 KB
v2-0003-Drop-resultmap-mechanism-from-pg_regress.patch text/x-patch 12.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2025-11-23 23:10:03 Remove header lock BufferGetLSNAtomic() on architectures with 64 bit atomic operations
Previous Message David Rowley 2025-11-23 22:52:21 Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length