Re: Fixing MSVC's inability to detect elog(ERROR) does not return

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing MSVC's inability to detect elog(ERROR) does not return
Date: 2026-07-05 21:54:40
Message-ID: CAApHDvr2+Gc5uuE3LvQqF4U3OoQLWkxSH7hhVUttz9fpAQ5iyA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 6 Jul 2026 at 03:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It came to my attention just now that 59c2f03d1 adjusted ereport()
> to be MSVC-friendly, but did not touch plpy_elog.h's PLy_elog(),
> which has a borrowed copy of the same logic. Was that intentional?

That was unintentional and caused by my unawareness of that version of
the macro.

> It seems like we should keep those looking alike.

Agreed.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeremy Schneider 2026-07-05 21:54:42 hang during shutdown
Previous Message Noah Misch 2026-07-05 21:47:20 Re: ri_Fast* crash w/ nullable UNIQUE constraint