Re: Fixing MSVC's inability to detect elog(ERROR) does not return

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing MSVC's inability to detect elog(ERROR) does not return
Date: 2026-07-05 22:15:31
Message-ID: 899795.1783289731@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Mon, 6 Jul 2026 at 03:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> It came to my attention just now that 59c2f03d1 adjusted ereport()
>> to be MSVC-friendly, but did not touch plpy_elog.h's PLy_elog(),
>> which has a borrowed copy of the same logic. Was that intentional?

> That was unintentional and caused by my unawareness of that version of
> the macro.

>> It seems like we should keep those looking alike.

> Agreed.

Cool. You wanna fix it, or shall I?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2026-07-05 22:21:15 Re: PG19 FK fast path: OOB write and missed FK checks during batched
Previous Message Tom Lane 2026-07-05 22:13:36 Re: Fix psql pager selection for wrapped expanded output