Re: Fixing MSVC's inability to detect elog(ERROR) does not return

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixing MSVC's inability to detect elog(ERROR) does not return
Date: 2026-07-05 15:18:28
Message-ID: 754534.1783264708@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> Now pushed and awaiting buildfarm feedback.

It came to my attention just now that 59c2f03d1 adjusted ereport()
to be MSVC-friendly, but did not touch plpy_elog.h's PLy_elog(),
which has a borrowed copy of the same logic. Was that intentional?
It seems like we should keep those looking alike.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2026-07-05 15:36:18 Re: POC: PLpgSQL FOREACH IN JSON ARRAY
Previous Message Sehrope Sarkuni 2026-07-05 15:13:58 Re: inconsistent jsonb 'null' conversions