| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: apply worker misses closing partition leaves |
| Date: | 2026-08-24 12:35:31 |
| Message-ID: | CAApHDvqNAoDiE5-JgdXktvFkZ5VW0jn9BEQybrcifj=_J=Kh6Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 24 Aug 2026 at 22:33, Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> The fix looks good to me. I just noticed one nit in the test:
>
> + ok(!$node->log_contains(qr/resource was not closed/),
> + 'unclosed resources on ' . $node->name);
>
> I think the test message should be: "no unclosed resources on".
Sorry, I must be missing something here. You want the message that
complains when there *is* a resource leak WARNING say "no unclosed
resources on $server"?
Maybe if that message is confusing, then it might be better to write
"resource leak detected on $server". Is that any better?
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-08-24 12:36:06 | Re: [PATCH] Several refactorings for pg_dump |
| Previous Message | Andrey Borodin | 2026-08-24 12:31:39 | Re: Use streaming read I/O when enabling data checksums online |